Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go version to 1.23.3 #440

Merged
merged 3 commits into from
Nov 19, 2024
Merged

update go version to 1.23.3 #440

merged 3 commits into from
Nov 19, 2024

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Nov 18, 2024

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner November 18, 2024 10:19
@miladz68 miladz68 requested review from masihyeganeh, dzmitryhil and ysv and removed request for a team November 18, 2024 10:19
masihyeganeh
masihyeganeh previously approved these changes Nov 18, 2024
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @ysv)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 17 files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @miladz68, and @ysv)


build/docker/docker_test.go line 44 at r2 (raw file):

	for _, tc := range testCases {
		tc := tc

Why did you remove it? And same for other such case?

Copy link
Contributor Author

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 17 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, and @ysv)


build/docker/docker_test.go line 44 at r2 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Why did you remove it? And same for other such case?

in newer version of go, this is no longer a reference and is a copy so it is not needed to copy it again. linter complains because of this.

dzmitryhil
dzmitryhil previously approved these changes Nov 19, 2024
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 17 files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)

Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 15 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@miladz68 miladz68 merged commit 4a2dd90 into master Nov 19, 2024
3 checks passed
@miladz68 miladz68 deleted the milad/update-go-version branch November 19, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants