-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update go version to 1.23.3 #440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 17 files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @miladz68, and @ysv)
build/docker/docker_test.go
line 44 at r2 (raw file):
for _, tc := range testCases { tc := tc
Why did you remove it? And same for other such case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 17 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, and @ysv)
build/docker/docker_test.go
line 44 at r2 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
Why did you remove it? And same for other such case?
in newer version of go, this is no longer a reference and is a copy so it is not needed to copy it again. linter complains because of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 17 files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 15 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ysv)
Description
Reviewers checklist:
Authors checklist
This change is