Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add community explorers #84

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

mamirpanah
Copy link
Contributor

@mamirpanah mamirpanah commented Nov 26, 2024

This change is Reviewable

Copy link
Collaborator

@alinetskyi alinetskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this PR!
Unfortunately, we can't merge it yet, Market Cap is displayed incorrectly on your explorer.
Screenshot 2024-12-17 at 12 12 24

@mamirpanah
Copy link
Contributor Author

Hello and thanks for your feedback
we are aware that market cap can be calculated via supply * price ( and we calculate based on this in our advanced analytics https://explorer.chainroot.io/advanced-analytics/coreum/market )
but as we and many other explorers use CoinGecko as a valid source of pricing and market cap info
the market cap in CoinGecko for Coreum is unfortunately not set, as you can see from link below:
https://www.coingecko.com/en/coins/coreum
however we have changed the market cap to show "-" instead of 0 to not to convey wrong meaning.

@alinetskyi
Copy link
Collaborator

I can still see that market cap is "$0"
Please let me know once you've updated it and we will merge this PR.
Screenshot 2025-01-13 at 10 56 48

@mamirpanah
Copy link
Contributor Author

Thanks for your attention, we updated our explorer and advanced-analytics to show "-" instead of 0 for Coreum to not to convey wrong meaning as said above.

@alinetskyi alinetskyi merged commit a290303 into CoreumFoundation:main Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants