Enable 2 Cluster Deployment of Corfu/LR #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shreayp
commented
Jan 12, 2024
shreayp
commented
- Clustered Corfu/LR deployment for rolling upgrade tests.
shreayp
force-pushed
the
lr-cloud
branch
2 times, most recently
from
61e3918
to
294d5ae
Compare
shreayp
force-pushed
the
lr-cloud
branch
10 times, most recently
from
b3f0064
to
40baafa
Compare
shreayp
force-pushed
the
lr-cloud
branch
4 times, most recently
from
5398400
to
ba44e66
Compare
xnull
reviewed
Feb 21, 2024
| @@ -0,0 +1,142 @@ | |||
| #!/bin/zsh | |||
There was a problem hiding this comment.
Just some thoughts:
When the sh script is getting complex you should switch to a better tool.
Maybe using python could be a better solution maybe some other autmation tool, like terraform.
Just to note, if you'd like to replace this sh with something else in the future, I'd be happy to support that activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.