Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer templates #57

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Footer templates #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80441d3
move footer from page.html.twig to html.html.twig
alisonjo315 Oct 7, 2022
42144b3
use flex-grid markup and aria-label attribute (copied from LASSP)
alisonjo315 Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions templates/html.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,48 @@
{{ page }}
{{ page_bottom }}

<footer id="body-footer" aria-label="Site footer">
<div class="main-footer">
<div class="container-fluid sidebar-left">
<div class="row">
<div class="flex-grid">
<div class="flex-4">
{{ page.footer_primary }}
</div>
<div class="flex-4">
{{ page.footer_secondary }}
</div>
<div class="flex-4">
{{ page.footer_tertiary }}
</div>
</div>
</div>
</div>
</div>
<div class="sub-footer">
<div class="container-fluid sidebar-left">
<div class="row">
<div class="content">
<div class="two-col">
<div>
<ul class="custom inline no-bullet">
{#<li><a href="https://www.cornell.edu">Cornell University</a> ©{{ "now"|date("Y") }}</li>#}
<li><a href="https://privacy.cornell.edu/">University Privacy</a></li>
</ul>
</div>
<div>
<ul class="custom inline no-bullet">
<li><a href="mailto:web-accessibility@cornell.edu">Web Accessibility Assistance</a></li>
</ul>
</div>
</div>
</div>
</div>
{{ page.subfooter }}
</div>
</div>
</footer>

<js-bottom-placeholder token="{{ placeholder_token|raw }}">
<!-- Emergency banner removed March 2021 -->
<!-- script src="https://embanner.univcomm.cornell.edu/OWC-emergency-banner.js" type="text/javascript" async></script -->
Expand Down
37 changes: 0 additions & 37 deletions templates/page.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,40 +101,3 @@
</div>
</div>
{% endif %}

<footer>
<div class="main-footer">
<div class="container-fluid sidebar-left">
<div class="row">
<div class="primary">
{{ page.footer_primary }}
</div>
<div class="secondary">
{{ page.footer_secondary }}
</div>
</div>
</div>
</div>
<div class="sub-footer">
<div class="container-fluid sidebar-left">
<div class="row">
<div class="content">
<div class="two-col">
<div>
<ul class="custom inline no-bullet">
{#<li><a href="https://www.cornell.edu">Cornell University</a> ©{{ "now"|date("Y") }}</li>#}
<li><a href="https://privacy.cornell.edu/">University Privacy</a></li>
</ul>
</div>
<div>
<ul class="custom inline no-bullet">
<li><a href="mailto:web-accessibility@cornell.edu">Web Accessibility Assistance</a></li>
</ul>
</div>
</div>
</div>
</div>
{{ page.subfooter }}
</div>
</div>
</footer>