Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated args / funcs #176

Merged
merged 8 commits into from
Sep 24, 2022
Merged

Conversation

calebchiam
Copy link
Collaborator

@calebchiam calebchiam commented Sep 4, 2022

Description

In preparation for ConvoKit 3.0, we are removing deprecated arguments and functions, such as:

  • The User component, and all user methods, e.g. has_user, get_user, iter_users, get_usernames
  • The name arg in Speaker
  • The root arg in Utterance
  • get_info and set_info -- in favor of add_meta and retrieve_meta
  • Various deprecated args in analysis transformers

Motivation and Context

This cleans up the API (see #85) and simplifies development. ConvoKit 3.0 -- aka major version update -- is the right time for these constructors / methods to be cleaned up.

How has this been tested?

Tested through CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant