Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS does not work on validation error #115

Closed
leplatrem opened this issue Feb 15, 2013 · 2 comments
Closed

CORS does not work on validation error #115

leplatrem opened this issue Feb 15, 2013 · 2 comments

Comments

@leplatrem
Copy link
Contributor

After a quick look at the code, it could be related to the bare response object built by the error_handler, thus bypassing CORS mechanism :
https://github.com/mozilla-services/cornice/blob/master/cornice/service.py#L470
https://github.com/mozilla-services/cornice/blob/master/cornice/util.py#L45

(Spotted on Daybed spiral-project/daybed#48)

@tdavis
Copy link

tdavis commented Mar 28, 2013

Yeah, I've started noticing this too. It makes debugging a huge pain.

@almet
Copy link
Contributor

almet commented May 13, 2013

This was fixed in 26606e4 and 21fde22

I didn't took the time to update here, but that should be okay by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants