Skip to content
This repository has been archived by the owner on Aug 2, 2019. It is now read-only.

CORS doesn't work on 404ed resources #48

Closed
almet opened this issue Feb 14, 2013 · 5 comments
Closed

CORS doesn't work on 404ed resources #48

almet opened this issue Feb 14, 2013 · 5 comments

Comments

@almet
Copy link
Member

almet commented Feb 14, 2013

when resources don't exist, we should return the right CORS headers. I'm not sure we're doing this ATM.
@leplatrem
Copy link
Contributor

It looks like this applies to 400 too.

Wouldn't it be a Cornice bug instead ?

@leplatrem
Copy link
Contributor

BTW, we have two ways of raising 404 :

https://github.com/spiral-project/daybed/blob/master/daybed/validators.py#L36
https://github.com/spiral-project/daybed/blob/master/daybed/views/data.py#L21, https://github.com/spiral-project/daybed/blob/master/daybed/views/definition.py#L23

@leplatrem leplatrem mentioned this issue Feb 15, 2013
Closed
@leplatrem
Copy link
Contributor

Note: could this be a typo ? (header(s)) : https://github.com/mozilla-services/cornice/blob/master/cornice/schemas.py#L92

leplatrem added a commit that referenced this issue Feb 15, 2013
@leplatrem
Return proper response objects for missing ressources (ref #48)
1146b0b
leplatrem added a commit that referenced this issue Feb 15, 2013
@leplatrem
Add explicit validation error if definition missing (ref #48)
709477c
@almet
Copy link
Member Author

almet commented Feb 18, 2013

ah right. I though I opened this to cornice. That's indeed a cornice bug.

@leplatrem
Copy link
Contributor

Closed in Cornice 👯 !

@leplatrem leplatrem mentioned this issue Sep 5, 2014
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@almet @leplatrem