Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: improve ambiguous block validation message #1417

Merged
merged 1 commit into from
Feb 2, 2023
Merged

core: improve ambiguous block validation message #1417

merged 1 commit into from
Feb 2, 2023

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Feb 2, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #1417 (57594a4) into master (8b5105a) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1417      +/-   ##
==========================================
+ Coverage   51.96%   51.98%   +0.01%     
==========================================
  Files         464      464              
  Lines       58429    58429              
==========================================
+ Hits        30365    30375      +10     
+ Misses      25755    25743      -12     
- Partials     2309     2311       +2     
Impacted Files Coverage Δ
core/block_validator.go 42.85% <0.00%> (ø)
rpc/server.go 76.27% <0.00%> (-6.78%) ⬇️
p2p/discover/table.go 84.19% <0.00%> (-2.44%) ⬇️
core/rawdb/chain_iterator.go 60.89% <0.00%> (-1.12%) ⬇️
trie/proof.go 75.45% <0.00%> (-0.91%) ⬇️
p2p/discover/v5_udp.go 81.14% <0.00%> (-0.44%) ⬇️
ctxc/downloader/downloader.go 77.51% <0.00%> (ø)
p2p/server.go 66.35% <0.00%> (+0.37%) ⬆️
ctxc/downloader/queue.go 80.46% <0.00%> (+0.46%) ⬆️
rpc/client.go 86.42% <0.00%> (+0.99%) ⬆️
... and 5 more

@ucwong ucwong merged commit 98fcaf1 into master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants