Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts/abi/bind: handle UnpackLog with zero topics #1483

Merged
merged 1 commit into from
Apr 8, 2023
Merged

accounts/abi/bind: handle UnpackLog with zero topics #1483

merged 1 commit into from
Apr 8, 2023

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Apr 8, 2023

Adds error handling for the case that UnpackLog or UnpackLogIntoMap is called with a log that has zero topics.


Adds error handling for the case that UnpackLog or UnpackLogIntoMap is called with a log that has zero topics.

---------

Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #1483 (3182316) into master (a228ece) will decrease coverage by 0.01%.
The diff coverage is 35.00%.

❗ Current head 3182316 differs from pull request most recent head 63790f4. Consider uploading reports for the commit 63790f4 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1483      +/-   ##
==========================================
- Coverage   52.15%   52.14%   -0.01%     
==========================================
  Files         474      474              
  Lines       59490    59492       +2     
==========================================
- Hits        31026    31023       -3     
- Misses      26115    26120       +5     
  Partials     2349     2349              
Impacted Files Coverage Δ
core/chain_indexer.go 63.47% <0.00%> (ø)
ctxcdb/pebble/pebble.go 33.60% <0.00%> (-0.27%) ⬇️
miner/worker.go 0.00% <0.00%> (ø)
params/version.go 33.33% <ø> (ø)
accounts/abi/bind/base.go 19.25% <33.33%> (+0.67%) ⬆️
core/state_prefetcher.go 36.36% <50.00%> (ø)
core/types/transaction.go 65.71% <50.00%> (+0.37%) ⬆️
core/blockchain.go 22.72% <62.50%> (ø)
common/types.go 68.96% <100.00%> (+3.44%) ⬆️
consensus/cuckoo/consensus.go 7.24% <100.00%> (+0.41%) ⬆️
... and 1 more

... and 13 files with indirect coverage changes

@ucwong ucwong merged commit c2f07ad into master Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants