Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core, miner: drop transactions from the same sender when error occurs… #1490

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Apr 15, 2023

This PR unifies the error handling in miner.

Whenever an error occur while applying a transaction, the transaction should be regarded as invalid and all following transactions from the same sender not executable because of the nonce restriction. The only exception is the nonceTooLow error which is handled separately.

… (#27038)

This PR unifies the error handling in miner.

Whenever an error occur while applying a transaction, the transaction should be regarded as invalid and all following transactions from the same sender not executable because of the nonce restriction. The only exception is the `nonceTooLow` error which is handled separately.
@ucwong ucwong marked this pull request as ready for review April 15, 2023 14:50
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #1490 (06dbee8) into master (0287be0) will increase coverage by 0.06%.
The diff coverage is 56.36%.

❗ Current head 06dbee8 differs from pull request most recent head df4ce32. Consider uploading reports for the commit df4ce32 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1490      +/-   ##
==========================================
+ Coverage   52.09%   52.15%   +0.06%     
==========================================
  Files         474      474              
  Lines       59489    59503      +14     
==========================================
+ Hits        30990    31033      +43     
+ Misses      26150    26117      -33     
- Partials     2349     2353       +4     
Impacted Files Coverage Δ
cmd/cortex/accountcmd.go 0.00% <0.00%> (ø)
cmd/cortex/main.go 21.73% <0.00%> (-0.59%) ⬇️
miner/worker.go 0.00% <0.00%> (ø)
accounts/abi/bind/base.go 19.25% <33.33%> (+0.67%) ⬆️
core/types/transaction.go 65.71% <50.00%> (+0.37%) ⬆️
core/txpool/txpool.go 74.79% <81.25%> (+0.37%) ⬆️
ctxc/downloader/downloader.go 77.40% <81.81%> (+0.10%) ⬆️
consensus/cuckoo/consensus.go 7.24% <100.00%> (+0.41%) ⬆️
core/state_transition.go 40.55% <100.00%> (ø)
core/txpool/list.go 88.25% <100.00%> (ø)
... and 2 more

... and 13 files with indirect coverage changes

@ucwong ucwong merged commit 06d32d4 into master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants