Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/state/snapshot: check difflayer staleness early #1548

Merged
merged 1 commit into from
May 25, 2023
Merged

core/state/snapshot: check difflayer staleness early #1548

merged 1 commit into from
May 25, 2023

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented May 24, 2023

This PR adds a staleness-check to AccountRLP, before checking the bloom-filter and potentially going directly into the disklayer.


This PR adds a staleness-check to AccountRLP, before checking the bloom-filter and potentially going directly into the disklayer.

---------

Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1548 (0344833) into master (c36f17b) will decrease coverage by 0.03%.
The diff coverage is 47.01%.

❗ Current head 0344833 differs from pull request most recent head bd70bd2. Consider uploading reports for the commit bd70bd2 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
- Coverage   52.68%   52.65%   -0.03%     
==========================================
  Files         476      479       +3     
  Lines       59723    59806      +83     
==========================================
+ Hits        31463    31489      +26     
- Misses      25896    25937      +41     
- Partials     2364     2380      +16     
Impacted Files Coverage Δ
client/ctxc_client.go 8.13% <0.00%> (-0.06%) ⬇️
cmd/cortex/main.go 21.73% <ø> (ø)
cmd/utils/flags.go 1.85% <0.00%> (-0.02%) ⬇️
core/asm/compiler.go 62.30% <0.00%> (+0.47%) ⬆️
crypto/kzg4844/kzg4844_ckzg_nocgo.go 0.00% <0.00%> (ø)
ctxc/api_backend.go 0.00% <0.00%> (ø)
p2p/msgrate/msgrate.go 14.28% <0.00%> (ø)
core/state/snapshot/difflayer.go 72.06% <14.28%> (-1.80%) ⬇️
crypto/kzg4844/kzg4844.go 34.48% <34.48%> (ø)
crypto/kzg4844/kzg4844_gokzg.go 64.70% <64.70%> (ø)
... and 7 more

... and 16 files with indirect coverage changes

@ucwong ucwong merged commit f458587 into master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants