Skip to content

Update 'google-java-format' 1.7 -> 1.9 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2020
Merged

Update 'google-java-format' 1.7 -> 1.9 #66

merged 2 commits into from
Dec 14, 2020

Conversation

zziga
Copy link
Contributor

@zziga zziga commented Dec 5, 2020 •
edited by reda-alaoui
Loading

Fixes #64

@reda-alaoui
Copy link
Member

Hello @zziga ,
Since this requires java 11, the major version needs to be bumped.

Could you please bump the major version in pom.xml and add a Breaking changes between 2.x to 3.x block to the readme?

@mqqx
Copy link

mqqx commented Dec 10, 2020

Hi @reda-alaoui,

why would it need java 11?

google-java-format uses java 8
https://github.com/google/google-java-format/blob/master/pom.xml#L97
so it should be fine?

Would be great to have this bump :)

@reda-alaoui
Copy link
Member

Because of what @zziga said at the end of #64

@mqqx
Copy link

mqqx commented Dec 10, 2020

nvm thanks..

@reda-alaoui
Copy link
Member

https://github.com/google/google-java-format/releases/tag/google-java-format-1.8

@zziga
Update 'google-java-format' 1.7 -> 1.9 Cosium#64
0918b7f 
- bump major version to 3.x
- add 'Breaking changes section 2.x to 3.x' to README.md
@reda-alaoui reda-alaoui changed the title Update 'google-java-format' 1.7 -> 1.9 #64 Update 'google-java-format' 1.7 -> 1.9 Dec 14, 2020
@reda-alaoui reda-alaoui merged commit d497735 into Cosium:master Dec 14, 2020
@reda-alaoui
Copy link
Member

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update 'google-java-format' 1.7 -> 1.9
3 participants
@zziga @reda-alaoui @mqqx