Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aggParams/scripting] use private modules, load in param controller #1

Merged
merged 2 commits into from
Oct 27, 2016
Merged

[aggParams/scripting] use private modules, load in param controller #1

merged 2 commits into from
Oct 27, 2016

Conversation

spalger
Copy link

@spalger spalger commented Oct 27, 2016

  • renamed the scripting_lang param type to script_lang
  • converted the scriptingLangs service to use Private module loader
  • moved loading of the scripting langs into the script_lang param controller
  • fixed the lang auto-select so that the first item is selected when there is only one
  • use painless as the default lang

spalger added 2 commits October 27, 2016 11:24
[aggParams/scripting] use private modules, load in param controller
fafc6e4 
 - renamed the scripting_lang param type to script_lang
 - converted the scriptingLangs service to use Private module loader
 - moved loading of the scripting langs into the script_lang param controller
 - fixed the lang auto-select so that the first item is selected when there is only one
[aggParam/script_lang] default to painless
47101c0
@spalger spalger mentioned this pull request Oct 27, 2016
Closed
@reda-alaoui reda-alaoui merged this pull request into Cosium:feature/add_scripted_metric_visualize Oct 27, 2016
reda-alaoui pushed a commit that referenced this pull request Nov 8, 2016
@spalger @reda-alaoui
[aggParams/scripting] use private modules, load in param controller (#1)
b6d05ab 
* [aggParams/scripting] use private modules, load in param controller

 - renamed the scripting_lang param type to script_lang
 - converted the scriptingLangs service to use Private module loader
 - moved loading of the scripting langs into the script_lang param controller
 - fixed the lang auto-select so that the first item is selected when there is only one

* [aggParam/script_lang] default to painless
@spalger spalger deleted the feature/add_scripted_metric_visualize branch October 18, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spalger @reda-alaoui