Merge pull request #1942 from CosmWasm/1779-remove-default-ibc-receiv…

…e-response

Remove `Default` impl for `IbcReceiveResponse`

CHANGELOG.md

@@ -67,12 +67,15 @@ and this project adheres to
  `ConversionOverflowError` and `DivideByZeroError`. ([#1896])
 - cosmwasm-std: Remove old IBC version and make v3 the default. ([#1875])
 - cosmwasm-storage: Removed, use [cw-storage-plus] instead. ([#1936])
+- cosmwasm-std: Remove `IbcReceiveResponse`'s `Default` implementation. Use
+ `IbcReceiveResponse::new` instead. ([#1942])
 
 [cw-storage-plus]: https://github.com/CosmWasm/cw-storage-plus
 [#1875]: https://github.com/CosmWasm/cosmwasm/pull/1875
 [#1890]: https://github.com/CosmWasm/cosmwasm/pull/1890
 [#1896]: https://github.com/CosmWasm/cosmwasm/pull/1896
 [#1936]: https://github.com/CosmWasm/cosmwasm/pull/1936
+[#1942]: https://github.com/CosmWasm/cosmwasm/pull/1942
 
 ## [1.5.0] - 2023-10-31
 

MIGRATING.md

@@ -107,12 +107,15 @@ major releases of `cosmwasm`. Note that you can also view the
  +const item: Item<Uint128> = Item::new("item");
  ```
 
-- Replace all uses of `IbcReceiveResponse::set_ack` with calls to
- `IbcReceiveResponse::new`:
+- Replace all uses of `IbcReceiveResponse::set_ack` and
+ `IbcReceiveResponse::default` with calls to `IbcReceiveResponse::new`:
 
  ```diff
- - Ok(IbcReceiveResponse::new().set_ack(b"{}"))
- + Ok(IbcReceiveResponse::new(b"{}"))
+ -Ok(IbcReceiveResponse::new().set_ack(b"{}"))
+ +Ok(IbcReceiveResponse::new(b"{}"))
+
+ -Ok(IbcReceiveResponse::default())
+ +Ok(IbcReceiveResponse::new(b""))
  ```
 
 ## 1.4.x -> 1.5.0

packages/std/src/ibc.rs

@@ -623,18 +623,6 @@ pub struct IbcReceiveResponse<T = Empty> {
  pub events: Vec<Event>,
 }
 
-// Custom implementation in order to implement it for all `T`, even if `T` is not `Default`.
-impl<T> Default for IbcReceiveResponse<T> {
- fn default() -> Self {
- IbcReceiveResponse {
- acknowledgement: Binary::default(),
- messages: vec![],
- attributes: vec![],
- events: vec![],
- }
- }
-}
-
 impl<T> IbcReceiveResponse<T> {
  /// Create a new response with the given acknowledgement.
  ///