Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decimal/Decimal256: Add new and raw const constructors #1264

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Decimal/Decimal256: Add new and raw const constructors #1264

merged 3 commits into from
Apr 4, 2022

Conversation

ueco-jb
Copy link
Contributor

@ueco-jb ueco-jb commented Apr 1, 2022

closes #1155
part of #1186

@ueco-jb ueco-jb requested a review from webmaster128 April 1, 2022 13:06
@ueco-jb ueco-jb self-assigned this Apr 1, 2022
@ueco-jb ueco-jb force-pushed the 1155-add-decimal-const-constructors branch 5 times, most recently from 7f058f0 to 2de9456 Compare April 4, 2022 09:25
webmaster128
webmaster128 reviewed Apr 4, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice APIs

packages/std/src/math/decimal.rs Show resolved Hide resolved
packages/std/src/math/decimal.rs Show resolved Hide resolved
packages/std/src/math/decimal.rs Outdated Show resolved Hide resolved
packages/std/src/math/decimal.rs Outdated Show resolved Hide resolved
packages/std/src/math/decimal256.rs Outdated Show resolved Hide resolved
packages/std/src/math/decimal256.rs Outdated Show resolved Hide resolved
packages/std/src/math/decimal256.rs Outdated Show resolved Hide resolved
packages/std/src/math/decimal256.rs Outdated Show resolved Hide resolved
packages/std/src/math/uint256.rs Show resolved Hide resolved
@ueco-jb ueco-jb requested a review from webmaster128 April 4, 2022 09:44
@ueco-jb ueco-jb force-pushed the 1155-add-decimal-const-constructors branch from 1420183 to e08b5c5 Compare April 4, 2022 11:09
@ueco-jb ueco-jb mentioned this pull request Apr 4, 2022
Closed
11 tasks
@ueco-jb ueco-jb merged commit 5ad8703 into main Apr 4, 2022
@ueco-jb ueco-jb deleted the 1155-add-decimal-const-constructors branch April 4, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees

@ueco-jb ueco-jb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decimal constructor is private
2 participants
@ueco-jb @webmaster128