Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decimal/Decimal256 - implement Rem/RemAssign #1340

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Decimal/Decimal256 - implement Rem/RemAssign #1340

merged 5 commits into from
Jun 29, 2022

Conversation

ueco-jb
Copy link
Contributor

@ueco-jb ueco-jb commented Jun 28, 2022

part of #1186

@ueco-jb ueco-jb requested a review from webmaster128 June 28, 2022 20:42
@ueco-jb ueco-jb self-assigned this Jun 28, 2022
webmaster128
webmaster128 reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you add a CHANGELOG entry?

@ueco-jb
Copy link
Contributor Author

ueco-jb commented Jun 29, 2022

@webmaster128 Right, forgot about it. Added right now.

@ueco-jb ueco-jb requested a review from webmaster128 June 29, 2022 08:34
@ueco-jb ueco-jb merged commit 955dd0c into main Jun 29, 2022
@ueco-jb ueco-jb deleted the 1186-decimal-rem branch June 29, 2022 08:36
@ueco-jb ueco-jb mentioned this pull request Jun 30, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees

@ueco-jb ueco-jb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ueco-jb @webmaster128