Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HexBinary type #1425

Merged
merged 9 commits into from
Sep 19, 2022
Merged

Add HexBinary type #1425

merged 9 commits into from
Sep 19, 2022

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Sep 15, 2022 •
edited
Loading

@webmaster128 webmaster128 requested a review from uint September 15, 2022 15:55
@webmaster128 webmaster128 changed the title Add HeyBinary type Add HexBinary type Sep 15, 2022
@webmaster128 webmaster128 added this to the 1.1.2 milestone Sep 19, 2022
uint
uint approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@uint uint self-requested a review September 19, 2022 11:43
uint
uint reviewed Sep 19, 2022
View reviewed changes
Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some typos!

docs/MESSAGE_TYPES.md Outdated Show resolved Hide resolved
@webmaster128 @uint
Update docs/MESSAGE_TYPES.md
ad82881 
Co-authored-by: Tomasz Kurcz <uint@lavabit.com>
@webmaster128 webmaster128 merged commit c3b02c8 into main Sep 19, 2022
@webmaster128 webmaster128 deleted the add-hexbinary branch September 19, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uint uint uint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@webmaster128 @uint