Remove msg argument from instantiate2_address #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
instantiate2_address-no-msg
branch
from
82bc785 to
3bc8f34
Compare
webmaster128
added a commit
that referenced
this pull request
Dec 20, 2022
webmaster128
force-pushed
the
instantiate2_address-no-msg
branch
from
c637702 to
ccf3f08
Compare
|
The context for this change can be found here: https://twitter.com/CosmWasm/status/1606198818780987392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed elsewhere, fixing the msg makes no sense if the contract creator can put the contract behind and address to any code and any state they want using the admin functionality. With this change, the usage of non-fixed predictable addresses gets easier.