Add #[must_use] to applicable math operations #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
reviewed
May 2, 2023
| @@ -10,6 +10,7 @@ pub trait Fraction<T>: Sized { | |||
| /// Returns the multiplicative inverse `q/p` for fraction `p/q`. | |||
| /// | |||
| /// If `p` is zero, None is returned. | |||
| #[must_use = "this returns the result of the operation, without modifying the original"] | |||
There was a problem hiding this comment.
Is this the right place here? Does this belong to the trait definition or the trait implementation?
There was a problem hiding this comment.
Yes, I think it has to go in the trait definition. When I put it on the impl, it does not trigger the warning.
chipshort
force-pushed
the
chipshort/issue1609
branch
from
cbe4b97
to
fbba7f6
Compare
webmaster128
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1609