Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IntoIterator for Coins #1806

Merged
merged 9 commits into from
Aug 16, 2023
Merged

Implement IntoIterator for Coins #1806

merged 9 commits into from
Aug 16, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1804
Allows iterating over Coins, both borrowed and owned.

jawoznia
jawoznia approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

webmaster128
webmaster128 reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and good to get this moving. However, let have a second though about the amount of symbols and code this will add. We might be better off storing Coin values in the Coins map.

packages/std/src/coins.rs Show resolved Hide resolved
packages/std/src/coin.rs Outdated Show resolved Hide resolved
packages/std/src/coin.rs Outdated Show resolved Hide resolved
@webmaster128 webmaster128 mentioned this pull request Aug 15, 2023
Closed
webmaster128
webmaster128 reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Some smaller comments but looks very good overall.

We need a CHANGELOG entry for the new iterator functionality and CoinFromStrError, CoinsError.

packages/std/src/coins.rs Outdated Show resolved Hide resolved
packages/std/src/coins.rs Show resolved Hide resolved
packages/std/src/coins.rs Show resolved Hide resolved
webmaster128
webmaster128 approved these changes Aug 15, 2023
View reviewed changes
packages/std/src/coins.rs Show resolved Hide resolved
packages/std/src/coins.rs Show resolved Hide resolved
chipshort and others added 6 commits August 16, 2023 14:23
@chipshort
Fix Coins Display impl
87ed3a7
@chipshort
Fix test
1eafab9
@chipshort @webmaster128
Simplify coins formatting
54fa676 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@chipshort
Implement ExactSizeIterator for Coins iterators
f1776c0
@chipshort
Add changelog entry for Coins iterators
b2460bb
@chipshort @webmaster128
Apply suggestions from code review
261cead 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@chipshort chipshort merged commit 9d1737d into main Aug 16, 2023
3 checks passed
@chipshort chipshort deleted the 1804-coin-iterator branch August 16, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

@jawoznia jawoznia jawoznia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Iterator<Item = Coin> for Coins
3 participants
@chipshort @webmaster128 @jawoznia