More Integer conversions #1861
Merged
More Integer conversions #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
commented
Sep 5, 2023
webmaster128
reviewed
Sep 5, 2023
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
webmaster128
reviewed
Sep 5, 2023
| output.copy_from_slice(&input[(INPUT_SIZE - OUTPUT_SIZE)..]); | ||
| Some(output) | ||
| } | ||
|
|
There was a problem hiding this comment.
Would be nice to try to upstream those. I.e. go from BInt::<X> to BInt::<Y>. Then you can also operate in 8 steps which should be faster.
There was a problem hiding this comment.
Actually, after looking into this, there seems to already be a way of casting them using bnum's CastFrom or As trait, but it needs nightly features to be const.
There was a problem hiding this comment.
Alright cool. This solution is good anyways. I just want to be nice and upstream ideas and code where possible.
webmaster128
approved these changes
Sep 5, 2023
webmaster128
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1855
Added some missing
FromandTryFromimpl to convert between signed integers.