Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Privatize CanonicalAddr, Binary and Size inner values #1876

Merged
merged 5 commits into from
Nov 6, 2023
Merged

[2.0] Privatize CanonicalAddr, Binary and Size inner values #1876

merged 5 commits into from
Nov 6, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1456

webmaster128
webmaster128 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a CHANGELOG an MIGRATING entry

@webmaster128 webmaster128 merged commit 3d56455 into main Nov 6, 2023
28 of 29 checks passed
@webmaster128 webmaster128 deleted the 1456-private-newtypes branch November 6, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make all newtype inner value private
2 participants
@chipshort @webmaster128