Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test zero-size InMemoryCache #1925

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Test zero-size InMemoryCache #1925

merged 2 commits into from
Oct 18, 2023

Conversation

webmaster128
Copy link
Member

Being able to set the in-memory cache size to 0 is relevant for the Wasm light client, which pins all codes anyways and should not waste and additional memory in this cache.

Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -117,6 +117,28 @@ mod tests {
// Based on `examples/module_size.sh`
const TESTING_WASM_SIZE_FACTOR: usize = 18;

const WAT1: &str = r#"(module
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@webmaster128 webmaster128 merged commit 884309c into main Oct 18, 2023
5 checks passed
@webmaster128 webmaster128 deleted the test-zero-memory-cache branch October 18, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants