Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ack required in IbcReceiveResponse::new #1940

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Make ack required in IbcReceiveResponse::new #1940

merged 5 commits into from
Nov 8, 2023

Conversation

chipshort
Copy link
Collaborator

@chipshort chipshort commented Nov 8, 2023 •
edited
Loading

closes #1649

pulled out of #1892

webmaster128
webmaster128 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just the CHANGELOG an MIGRATING entry

@chipshort chipshort merged commit edada3e into main Nov 8, 2023
27 of 28 checks passed
@chipshort chipshort deleted the 1649-ack-required branch November 8, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make acknowledgement required in IbcReceiveResponse::new
2 participants
@chipshort @webmaster128