Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add heap profiler using dhat-rs #1955

Merged
merged 9 commits into from
Jan 16, 2024
Merged

Add heap profiler using dhat-rs #1955

merged 9 commits into from
Jan 16, 2024

Conversation

webmaster128
Copy link
Member

No description provided.

@webmaster128 webmaster128 mentioned this pull request Dec 23, 2023
Closed
@webmaster128 webmaster128 mentioned this pull request Dec 28, 2023
Open
@webmaster128 webmaster128 marked this pull request as ready for review January 9, 2024 16:16
@webmaster128 webmaster128 requested a review from chipshort January 9, 2024 16:16
@chipshort
Copy link
Collaborator

IMHO, this is fine to merge now.
I had to move the dhat dependency to a runtime dependency to get Windows CI to build it, but it's only enabled when the feature is enabled, so that should be fine. Alternative would be to keep it a dev-dependency and install mingw in the CI.

webmaster128
webmaster128 commented Jan 11, 2024
View reviewed changes
@chipshort chipshort force-pushed the dhat-heap-profiling branch from db4da72 to a01f9c1 Compare January 16, 2024 10:33
webmaster128
webmaster128 commented Jan 16, 2024
View reviewed changes
Copy link
Member Author

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@webmaster128 webmaster128 merged commit 2122667 into main Jan 16, 2024
5 checks passed
@webmaster128 webmaster128 deleted the dhat-heap-profiling branch January 16, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipshort chipshort Awaiting requested review from chipshort

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmaster128 @chipshort