-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QueryRequest::Grpc
#1973
Add QueryRequest::Grpc
#1973
Conversation
Let's deprecate it. The migration is not fully trivial since the contract needs to change the decoding from JSON to protobuf. It's a bit nicer to give people time for that. |
cce99ef
to
58f751c
Compare
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
58f751c
to
e1aa326
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could get a sentence or two in MIGRATING.md, especially highlighting the return data format being binary (for real this time 🤞)
closes #1966
Do we also want to remove / deprecate the Stargate query? Only on the contract side ofc, since we need to continue supporting it in wasmd for 1.x compatibility.