Async Acknowledgement #2130
Merged
Async Acknowledgement #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
force-pushed
the
chipshort/async-ack
branch
from
c9b4920
to
b2889cd
Compare
chipshort
force-pushed
the
chipshort/async-ack
branch
from
a945804
to
41ab03f
Compare
chipshort
force-pushed
the
chipshort/async-ack
branch
from
83a5581
to
e1be535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1721
This is a proposal for the async acknowledgement implementation. Happy to get opinions on this.
The packet can be identified by the combination of port, channel and sequence.
The port is unique to each contract and known to wasmd, so it's not needed to provide that explicitly.
To implement this in wasmd, we need to save the packet under some unique key (combination of the three data pieces above) when the contract returns no ack from
ibc_packet_receive. Later when the contract callsWriteAcknowledgement, we try to load that saved packet and call the ibc-goWriteAcknowledgementfunction.If this general approach sounds good then I can provide an implementation for wasmd.