Rebalance gas cost #2152
Merged
Rebalance gas cost #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
commented
May 24, 2024
webmaster128
approved these changes
May 30, 2024
aumetra
approved these changes
May 30, 2024
chipshort
force-pushed
the
chipshort/gas-benchmarking
branch
from
abe9af3
to
ebbe201
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2143
I updated the
GasConfigvalues andcostfunction according to the benchmark on the benchmark server.I also changed the way we charge
ed25519_batch_verifygas to fit better with the actual execution time. The calculation is now similar to that of the BLS functions, so I refactored this a bit.I also addressed this old todo, since we are changing gas costs in tests anyways with this rebalancing. I don't think it's super important that we are exactly the same as wasmd here, but multiple orders of magnitude off seemed a bit much.