Conditional migrate call with extra MigrateInfo argument after contract update #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
from
6fef09a
to
ef3da24
Compare
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
2 times, most recently
from
92ee454
to
6ecd9a6
Compare
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
2 times, most recently
from
32fd38b
to
d0356bc
Compare
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
from
d0356bc
to
f6ffb68
Compare
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
from
25d378b
to
f15c71c
Compare
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
5 times, most recently
from
e19ee2c
to
a24f2c0
Compare
kulikthebird
commented
Sep 2, 2024
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
3 times, most recently
from
b85cbe5
to
0b589db
Compare
chipshort
reviewed
Sep 2, 2024
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
from
0b589db
to
2618bd9
Compare
chipshort
approved these changes
Sep 3, 2024
webmaster128
approved these changes
Sep 3, 2024
| Err(err) | ||
| } | ||
| }) | ||
| } |
There was a problem hiding this comment.
Yeah, exactly – this is super nice. All users of cosmwasm-vm can benefit from the feature now and we have strong typing
packages/vm/src/environment.rs
Outdated
| @@ -272,6 +272,10 @@ impl<A: BackendApi, S: Storage, Q: Querier> Environment<A, S, Q> { | |||
| let func = instance.exports.get_function(name)?; | |||
| Ok(func.clone()) | |||
| })?; | |||
| let function_arity = func.param_arity(store); | |||
| if args.len() != function_arity { | |||
| return Err(VmError::function_arity_mismatch()); | |||
There was a problem hiding this comment.
I would add function arity and number of args as additional info fields to the error for the sake of debugability when something unexpected happens. But this is nice to have and not needed for the feature.
|
Forgot one more thing: Can you add a CHANGELOG entry for this? (rebase on main before that, since I just merged another PR) |
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
from
2618bd9
to
c09d19e
Compare
kulikthebird
force-pushed
the
tkulik/conditional_migrate
branch
from
a02a90e
to
53643a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.