Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Featureless entrypoints #2246

Merged
merged 11 commits into from
Sep 23, 2024
Merged

Featureless entrypoints #2246

merged 11 commits into from
Sep 23, 2024

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Sep 9, 2024 •
edited
Loading

Closes #1627

After merging and releasing this, we can just remove any and all mention of the library feature :P

@aumetra aumetra marked this pull request as draft September 9, 2024 12:51
@aumetra aumetra marked this pull request as ready for review September 9, 2024 13:17
chipshort
chipshort reviewed Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff!
Can we test this using one of the actual contracts? Like one of them importing another one and then showing that it compiles and that it still works correctly in an integration test?

@aumetra
Copy link
Member Author

aumetra commented Sep 9, 2024

Yep, that's the idea. Gonna add that tomorrow and then we can hit the big merge button

webmaster128
webmaster128 reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. It feels a bit too easy to be true to be honest. But I don't see any issue with that approach.

packages/vm/src/modules/cached_module.rs Outdated Show resolved Hide resolved
@aumetra
Copy link
Member Author

aumetra commented Sep 10, 2024

It feels a bit too easy to be true to be honest

Kinda does, doesn't it. But the CI checks seem to verify that it does work (also did some tests with proc-macros first; but it seems that it does what it should do)

chipshort
chipshort reviewed Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice!
Can you do some cleanup on the new contracts? I would remove the license files, .editorconfig, .gitignore and the README of the inner-contract.

contracts/nested-contracts/README.md Outdated Show resolved Hide resolved
chipshort
chipshort approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@aumetra aumetra merged commit 82f3567 into main Sep 23, 2024
35 checks passed
@aumetra aumetra deleted the aw/featureless-entrypoint branch September 23, 2024 06:57
@Richardweb1
Copy link

thank you to share it

@larry0x larry0x mentioned this pull request Oct 12, 2024
Open
aumetra added a commit that referenced this pull request Oct 22, 2024
@aumetra
Revert "Merge pull request #2246 from CosmWasm/aw/featureless-entrypo…
7d16d9a 
…int"

This reverts commit 82f3567, reversing
changes made to 45b4629.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipshort chipshort chipshort approved these changes

@kulikthebird kulikthebird Awaiting requested review from kulikthebird

@webmaster128 webmaster128 Awaiting requested review from webmaster128

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convention: Negate "library" feature?
4 participants
@aumetra @Richardweb1 @webmaster128 @chipshort