chore: Add deprecation mark #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 10, 2024
kulikthebird
force-pushed
the
tkulik/deprecate_variants
branch
4 times, most recently
from
eca7348
to
463996c
Compare
chipshort
reviewed
Sep 10, 2024
packages/std/src/query/bank.rs
Outdated
| @@ -25,6 +25,7 @@ pub enum BankQuery { | |||
| /// This calls into the native bank module for all denominations. | |||
| /// Note that this may be much more expensive than Balance and should be avoided if possible. | |||
| /// Return value is AllBalanceResponse. | |||
| #[deprecated] | |||
There was a problem hiding this comment.
Can we also add an explanatory text here? Similar to the other one: "Returns a potentially unbound number of results, which is inherently vulnerable to attacks. If you think you have a valid usecase, please open an issue."
kulikthebird
force-pushed
the
tkulik/deprecate_variants
branch
from
eb67818
to
6cf95e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.