Add burn contract #413
Add burn contract #413
Conversation
ethanfrey
force-pushed
the
add-burn-contract
branch
from
32bde26 to
49e7ab3
Compare
|
I addressed all PR comments. Waiting for CI and a re-review |
|
|
||
| /// HandleMsg is a placeholder where we don't take any input | ||
| #[derive(Serialize, Deserialize, Clone, Debug, PartialEq, JsonSchema)] | ||
| pub struct HandleMsg {} |
There was a problem hiding this comment.
Actually, I want it to accept anything, so I can give the custom error message in the code ("only supports migration") rather than some obstuse json parse error
There was a problem hiding this comment.
Hmm, since the wasm implementation of serde JSON does not have an any type, I don't think this is possible in a non-hacky way. You can leave it like this, which probably accepts any JSON object as an input and ignored all extra fields.
|
|
||
| /// QueryMsg is a placeholder where we don't take any input | ||
| #[derive(Serialize, Deserialize, Clone, Debug, PartialEq, JsonSchema)] | ||
| pub struct QueryMsg {} |
There was a problem hiding this comment.
See above. I would rather accept any struct and return Err(generic_err("You can only use this contract for migrations"))
What do you think? A better suggestion for error message?
There was a problem hiding this comment.
If this is a use case we want to promote, I think the nicest way would be to make the init/handle/query exports optional. Then we get the best error reporting by the VM: e.g. this contract does not support init
Closes #387
Adds a simple contract to test migrations