Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust to 1.45.2 #522

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Update Rust to 1.45.2 #522

merged 2 commits into from
Sep 8, 2020

Conversation

webmaster128
Copy link
Member

Closes #444

@webmaster128
Update Rust version to 1.45.2
570084b
@webmaster128
Update NIGHTLY_TOOLCHAIN for clippy

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
71257dd
@webmaster128 webmaster128 added this to the 0.11.0 milestone Sep 8, 2020
ethanfrey
ethanfrey approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Did you say we don't need nightly once we have 1.45? Or do we need 1.45 + wasmer-reborn to remove the nightly dependency?

.circleci/config.yml
environment:
# Make sure to choose version with clippy present: https://rust-lang.github.io/rustup-components-history/x86_64-unknown-linux-gnu.html
NIGHTLY_TOOLCHAIN: nightly-2020-05-26
NIGHTLY_TOOLCHAIN: nightly-2020-09-08
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite the jump

@webmaster128
Copy link
Member Author

Did you say we don't need nightly once we have 1.45? Or do we need 1.45 + wasmer-reborn to remove the nightly dependency?

Wasmer Reborn is required. 0.17.x did not get the necessary dynasm update (wasmerio/wasmer#1489). So this is mostly a preparation step.

@webmaster128 webmaster128 merged commit 5df197b into master Sep 8, 2020
@webmaster128 webmaster128 deleted the update-rust-to-1.45.2 branch September 8, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

Document and bump min Rust version to 1.45.0
2 participants
@webmaster128 @ethanfrey