Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Display for Coin #901

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Implement Display for Coin #901

merged 1 commit into from
Apr 26, 2021

Conversation

webmaster128
Copy link
Member

Closes #899

@webmaster128
Copy link
Member Author

webmaster128 commented Apr 26, 2021 •
edited
Loading

By the way, we have parsers for this format in CosmJS: https://github.com/cosmos/cosmjs/blob/v0.25.0-alpha.3/packages/amino/src/coins.ts#L22-L38

ethanfrey
ethanfrey approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@webmaster128 webmaster128 merged commit 6ecf995 into main Apr 26, 2021
@webmaster128 webmaster128 deleted the display-coin branch April 26, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

@maurolacy maurolacy Awaiting requested review from maurolacy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add helpers to stringify coins
2 participants
@webmaster128 @ethanfrey