Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weight 0 vs not member #159

Merged
merged 5 commits into from
Dec 7, 2020
Merged

Weight 0 vs not member #159

merged 5 commits into from
Dec 7, 2020

Conversation

maurolacy
Copy link
Contributor

Now, closes #154.

@maurolacy maurolacy mentioned this pull request Dec 7, 2020
Closed
ethanfrey
ethanfrey reviewed Dec 7, 2020
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VoterInfo looks good.

But VoterResponse still has the Option weight. It shouldn't be optional

@maurolacy
Copy link
Contributor Author

Oh, I see, good catch. I reverted it in my branch, but it came back from the rebase. Shoud be fixed now.

ethanfrey
ethanfrey approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ethanfrey ethanfrey merged commit f996203 into master Dec 7, 2020
@ethanfrey ethanfrey deleted the weight-0-vs-not-member branch December 7, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distinguish between weight 0 and not member in cw3 queries
2 participants
@maurolacy @ethanfrey