Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace byte slices by string slices in names and constructors #173

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Replace byte slices by string slices in names and constructors #173

merged 1 commit into from
Dec 11, 2020

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Dec 11, 2020 •
edited
Loading

Closes #170.

I focused in names & ctors. Possibly other things can be changed as well, in other PR / PRs:

  • key(), prefix()
  • to_length_prefixed()
  • nested_namespace_with_keys()
  • load(), update(), save(), may_load(), ...
  • Bound
  • ...

ethanfrey
ethanfrey approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

packages/cw4/src/query.rs Show resolved Hide resolved
contracts/cw721-base/src/state.rs Show resolved Hide resolved
packages/storage-plus/src/item.rs Show resolved Hide resolved
@ethanfrey ethanfrey merged commit 940775a into master Dec 11, 2020
@ethanfrey ethanfrey deleted the byte-slices-to-str branch December 11, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update namespaces / constructors to accept &str
2 participants
@maurolacy @ethanfrey