Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cw1-subkeys helper.ts and point to heldernet #202

Merged
merged 2 commits into from
Dec 22, 2020

Conversation

orkunkl
Copy link
Contributor

@orkunkl orkunkl commented Dec 21, 2020

This change is required for coralnet to heldernet update in docs.

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Same general comment as #201

Only major change needed is setting a cosmjs version in the header.

defaultKeyFile: path.join(process.env.HOME, ".heldernet.key"),
gasLimits: {
upload: 1500000,
init: 600000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these can be brought down a lot. We know what the contract does.

Anyway, low priortiy, you can merge without this. Just want to mark it as a TODO

@orkunkl
Copy link
Contributor Author

orkunkl commented Dec 22, 2020

Same question goes for this PR: #201 (comment)

@ethanfrey
Copy link
Member

We used v0.10.4, see here

Nice to point this out. v0.4.0 will be built with v0.10.7

@ethanfrey ethanfrey merged commit 03b6433 into master Dec 22, 2020
@ethanfrey ethanfrey deleted the fix-cw1-subkeys-helper branch December 22, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants