Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make self constant in Item::update #218

Merged
merged 1 commit into from
Jan 10, 2021
Merged

Make self constant in Item::update #218

merged 1 commit into from
Jan 10, 2021

Conversation

webmaster128
Copy link
Member

Closes #217

ethanfrey
ethanfrey approved these changes Jan 10, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, we no longer need &mut self anywhere in the storage plus storage helpers

@webmaster128
Copy link
Member Author

Yeah, storage is mutable but not the config

@webmaster128 webmaster128 merged commit 8b16df3 into master Jan 10, 2021
@webmaster128 webmaster128 deleted the unmut-config branch January 10, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix const_item_mutation warnings
2 participants
@webmaster128 @ethanfrey