Run clippy on test code

[webmaster128]

No description provided.

[ethanfrey]

Good stuff and thanks to fix the tests below.

Just curious as to the best flags to run clippy with

[ethanfrey]

Nice idea. Did you check if this also runs clippy on non-test code (cargo clippy --help doesn't clarify that)

The recommendation from clippy seems to be:

  # if you want the build job to fail when encountering warnings, use
  - cargo clippy -- -D warnings
  # in order to also check tests and non-default crate features, use
  - cargo clippy --all-targets --all-features -- -D warnings

[webmaster128]

Nice find. We cannot use --all-features because of

[features]
backtraces = ["cosmwasm-std/backtraces"]

which only compiles using Rust nightly. But --all-targets is a nice alternative to --tetsts.