Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose contract components #293

Merged
merged 2 commits into from
May 19, 2021
Merged

Expose contract components #293

merged 2 commits into from
May 19, 2021

Conversation

orkunkl
Copy link
Contributor

@orkunkl orkunkl commented May 19, 2021

When importing/extending contracts, access to base contract's errors, msgs required. This PR will allow that.

@orkunkl orkunkl requested a review from webmaster128 May 19, 2021 10:03
ethanfrey
ethanfrey approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for exporting these.
And nice follow up from the training

@ethanfrey ethanfrey merged commit 0daeb17 into main May 19, 2021
@ethanfrey ethanfrey deleted the expose-contract-errs branch May 19, 2021 10:28
@orkunkl orkunkl mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

@maurolacy maurolacy Awaiting requested review from maurolacy

@webmaster128 webmaster128 Awaiting requested review from webmaster128

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orkunkl @ethanfrey