-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify multitest storage #335
Conversation
5c61984
to
83e1aa2
Compare
Okay, this massive PR is ready for review. It is a quasi-rewrite of the internals of multi-test, keeping a very similar API. I think it makes everything much clearer and extensible, and lays the groundwork to easily add more "Keepers" to mock out staking, or handle custom messages |
Can you add some context / description of the changes? It is impossible for me to review this in any meaningful way. Too many changes, that are unrelated, or at least, difficult to relate to the previous code base. |
Yeah, I would just review the new codebase, and not the diff. The comments above were helpful to identify that. |
@maurolacy I added a DESIGN.md file that should help. I would not review the diff, but rather review the new code by itself. You can add comments on the diff, but this is basically a re-write, so it makes more sense to look at it as a whole.
|
Thanks. I'll take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the DESIGN doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but this is still above my head. Need to get more exposure to both using and modifying / extending multi-test.
Thanks for the feedback. I will update and merge. |
merge after #334
Major overhaul of how storage and caching works in multi-test.
This should allow for much more extensibility in multi-test in the future