Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how cw20 minting is supposed to work #355

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

ethanfrey
Copy link
Member

Closes #339

@ethanfrey ethanfrey requested a review from maurolacy July 26, 2021 10:09
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

If initial supply is 1000 and cap is `Some(2000)`, you can only mint 1000 more tokens.
However, if someone then burns 500 tokens, the minter can mint those 500 again.
This allows for dynamic token supply within a set of parameters, especially when
the minter is a smart contract.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@ethanfrey ethanfrey merged commit d8d3d7f into main Jul 26, 2021
@ethanfrey ethanfrey deleted the clarify-meaning-of-cw20-minting branch July 26, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why cw20-base do not care about minting cap?
2 participants