Add send and sendFrom to cw20-base helpers.ts #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orkunkl
changed the title
ethanfrey
reviewed
Sep 12, 2021
contracts/cw20-base/helpers.ts
Outdated
| @@ -265,6 +268,16 @@ export const CW20 = (client: SigningCosmWasmClient, fees: Options["fees"]): CW20 | |||
| return result.transactionHash; | |||
| } | |||
|
|
|||
| const send = async (senderAddress: string, recipient: string, amount: string, msg: Record<string, unknown>): Promise<string> => { | |||
| const result = await client.execute(senderAddress, contractAddress, {send: {recipient, amount, msg: toUtf8(JSON.stringify(msg))}}, fees.exec); | |||
There was a problem hiding this comment.
One more step needed here (maybe you can pull this out to a function jsonToBinary
msg: toBase64(toUtf8(JSON.stringify(msg)))
We want to explicitly make it a base64-encoded string. I think the default JSON serialisation in JS land for Uint8Array is [43, 91, 81, ...], which is not what we want
contracts/cw20-base/helpers.ts
Outdated
| } | ||
|
|
||
| const sendFrom = async (senderAddress: string, owner: string, recipient: string, amount: string, msg: Record<string, unknown>): Promise<string> => { | ||
| const result = await client.execute(senderAddress, contractAddress, {send_from: {owner, recipient, amount, msg: toUtf8(JSON.stringify(msg))}}, fees.exec); |
There was a problem hiding this comment.
Same here with the msg encoding
ethanfrey
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements essential
sendandsendFromfor cw20-base/helpers.ts