Snapshot item 2 #418
Merged
Snapshot item 2 #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
maurolacy
force-pushed
the
snapshot-item-2
branch
from
172c2c2
to
f55ce7f
Compare
ethanfrey
approved these changes
Sep 14, 2021
| Ok(Some(Some(100))) | ||
| ); | ||
|
|
||
| // Write a changelog at 4, removing the value |
There was a problem hiding this comment.
removing the value? that doesn't make sense to me
There was a problem hiding this comment.
Why not? It would be tantamount to removing the key. It's supported, so I think it must be tested. Also, I like seeing Some(None) in the results.
These None cases are also present in the original test for SnapshotMap AFAIK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#409 follow-up. Refactors into a
snapshotmodule, and addsSnapshotunit tests.