Improve error handling / remove FIXMEs #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
reviewed
Oct 4, 2021
ethanfrey
previously approved these changes
Oct 4, 2021
maurolacy
force-pushed
the
key_deserializer-errors
branch
from
30913b7
to
549c2b5
Compare
|
Approval was automatically dismissed or so. |
ethanfrey
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
Awesome.
BTW, at the backlog meeting during your vacation the other devs all asked for strict protected branch rules... no push on Master, no merge pr without approval and CI checks passing, dismiss stale reviews.
I applied on all rust repos I maintain. We can discuss these rules if you don't like them, happy to implement what the team requests
|
I agree with those rules, except perhaps dismiss stale reviews. An author can always request a new review over an already approved PR, if he deems it necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve utf-8 error handling.
Remove FIXMEs for
SliceErrors.