cw1-subkeys-ng: Additional follow up improvements #506
Conversation
| @@ -3,11 +3,12 @@ pub mod error; | |||
| pub mod interfaces; | |||
| pub mod msg; | |||
| pub mod multitest; | |||
| #[cfg(any(test, feature = "querier"))] | |||
There was a problem hiding this comment.
did this have any effect?
I assume it would have been optimised away, but curious if this affects was size.
There was a problem hiding this comment.
It may not be it is to be chcecked. The reason why they may not be optimized is, that they are public and visible from this point, and our wasm binaries are actually wasm libraries, so I am pretty sure optimizer has no rights to cut them off. I think, that in librray builds any dispatcher would not occur in the library, because they are pub(crate), and if I don't generate neither entry points nor multitest helpers they are straightly deadcode, so cut off, but not in this case.
|
Just tested it and this flag has no effect on contract size; the artifact is exactly the same as before. I would say, let's remove this feature before merging. |
|
If you turn on the library flag, there are also a lot of pub fn but no entry points beyond those standard ones for allocate, etc build into cosmwasm-std. This weighs in like 10kb. So, yeah, pretty much anything not reachable from an entry point should be stripped off when running through the optimizer (maybe wasm-opt not rust, we use both) Happy to remove that feature flag and keep the rest |
Additional upgrades of cw1-subkeys-ng contracts.
Mosltly naming, but also hiding quriers behind feature flag so they are not generated in wasm binary.