Use protobuf de helpers #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add serialiation / deserialization traits to them
ethanfrey
approved these changes
Oct 27, 2021
| @@ -7,13 +9,13 @@ const WIRE_TYPE_LENGTH_DELIMITED: u8 = 2; | |||
| // Up to 9 bytes of varints as a practical limit (https://github.com/multiformats/unsigned-varint#practical-maximum-of-9-bytes-for-security) | |||
| const VARINT_MAX_BYTES: usize = 9; | |||
|
|
|||
| #[derive(Clone, Debug, PartialEq)] | |||
| #[derive(Serialize, Deserialize, Clone, PartialEq, JsonSchema, Debug)] | |||
There was a problem hiding this comment.
Why do we serialize? (As JSON)
There was a problem hiding this comment.
I thought it would be useful.
We need to "binarize" these messages, not serialise them.
There was a problem hiding this comment.
Yeah. I prefer no json methods.
We can add method to protobuf serialise in the future. (which could be used in multitest for example).
There was a problem hiding this comment.
merging now, so I can start linking. feel free to clean up later.
ethanfrey
reviewed
Oct 27, 2021
| @@ -856,11 +857,11 @@ pub fn parse_contract_addr(data: &Option<Binary>) -> AnyResult<Addr> { | |||
| .ok_or_else(|| anyhow!("No data response"))? | |||
| .to_vec(); | |||
| // parse the protobuf struct | |||
| let init_data = InstantiateData::decode(bin.as_slice())?; | |||
There was a problem hiding this comment.
Ah, this is the example I can link to. I guess it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use protobuf helpers to deserialize response in wasm executor
instantiate_contract.Also, add a couple extra useful methods, and publish structs so that they can be used directly.
Also, add deserialization / serialization traits to them.