Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement display for Balance and Coin #565

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Implement display for Balance and Coin #565

merged 3 commits into from
Dec 2, 2021

Conversation

orkunkl
Copy link
Contributor

@orkunkl orkunkl commented Dec 1, 2021

Need this for a project and thought would be great to have it in std.
Not sure if formatting follows best practices.

@orkunkl orkunkl requested review from ueco-jb and uint December 1, 2021 08:23
@uint
Copy link
Contributor

uint commented Dec 1, 2021

Looks good. I don't think there are best practices for Display formatting except "it's for user-facing output, so make it look good."

cosmwasm_std already does this for Coin in a different format though. It'd probably be good to be consistent.

orkunkl
orkunkl commented Dec 1, 2021
View reviewed changes
packages/cw0/src/balance.rs Outdated Show resolved Hide resolved
uint
uint approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ueco-jb
ueco-jb approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orkunkl orkunkl merged commit b4e0c60 into main Dec 2, 2021
@orkunkl orkunkl deleted the balance-display branch December 2, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueco-jb ueco-jb ueco-jb approved these changes

@uint uint uint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orkunkl @uint @ueco-jb