Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IntKey and TimestampKey #620

Merged
merged 3 commits into from
Jan 3, 2022
Merged

Remove IntKey and TimestampKey #620

merged 3 commits into from
Jan 3, 2022

Conversation

ueco-jb
Copy link
Contributor

@ueco-jb ueco-jb commented Jan 3, 2022

closes #570

@ueco-jb ueco-jb self-assigned this Jan 3, 2022
@ueco-jb ueco-jb force-pushed the 570-remove-intkey branch 2 times, most recently from be40bf0 to 6aa82e4 Compare January 3, 2022 12:54
@ueco-jb ueco-jb marked this pull request as ready for review January 3, 2022 12:57
@ueco-jb ueco-jb changed the title Remove IntKey and TimestampKey Remove IntKey and TimestampKey; Rename CwIntKey to IntKey Jan 3, 2022
maurolacy
maurolacy approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@maurolacy maurolacy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Only doubt I have is with renaming CwIntKey in this PR / release round.

We'll leave IntKeyOld for a while as well. So, perhaps doing the renaming above when removing IntKeyOld is a good idea.

Approving anyway, as I think this is a viable option.

packages/storage-plus/src/de.rs Outdated Show resolved Hide resolved
@ueco-jb ueco-jb changed the title Remove IntKey and TimestampKey; Rename CwIntKey to IntKey Remove IntKey and TimestampKey Jan 3, 2022
@ueco-jb ueco-jb merged commit fa0c5ac into main Jan 3, 2022
@ueco-jb ueco-jb deleted the 570-remove-intkey branch January 3, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy approved these changes

@hashedone hashedone Awaiting requested review from hashedone

@ethanfrey ethanfrey Awaiting requested review from ethanfrey

@uint uint Awaiting requested review from uint

Assignees

@ueco-jb ueco-jb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove IntKey with surrounding implementation
2 participants
@ueco-jb @maurolacy