Allow modifying admin of Ics20 contract #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ethanfrey
commented
Jan 31, 2022
ethanfrey
commented
- Use ADMIN rather then config
- Support standard ADMIN query and update
- Add migration support from current version to new version
maurolacy
approved these changes
Jan 31, 2022
| Ok(Response::new()) | ||
| } | ||
|
|
||
| fn from_semver(err: semver::Error) -> StdError { |
| @@ -251,9 +298,10 @@ pub fn query_channel(deps: Deps, id: String) -> StdResult<ChannelResponse> { | |||
|
|
|||
| fn query_config(deps: Deps) -> StdResult<ConfigResponse> { | |||
| let cfg = CONFIG.load(deps.storage)?; | |||
| let admin = ADMIN.get(deps)?.unwrap_or_else(|| Addr::unchecked("")); | |||
There was a problem hiding this comment.
Nice. Wouldn't "None" be better here? I think we used that in the past.
There was a problem hiding this comment.
In this contract, we don't allow None, so it doesn't map much to the ADMIN, I kind of force it
| } | ||
|
|
||
| Ok(Response::new()) | ||
| } |
There was a problem hiding this comment.
Not for now, but I wonder how much of this logic can be turned into a helper function.
There was a problem hiding this comment.
some of this is in poe-contracts/tg-utils
but matching on versions would be a good thing to abstract out (later, when we have some good examples/experience)
ethanfrey
force-pushed
the
ics20-modify-admin
branch
from
2a0d550
to
20c2177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.